Clear up one TODO and update comments on some more

This commit is contained in:
Ian Renton
2026-06-20 08:33:00 +01:00
parent 20966cc7cf
commit 1e42c69b78
3 changed files with 11 additions and 10 deletions

View File

@@ -14,15 +14,14 @@ with open("config.yml") as f:
config = yaml.safe_load(f) config = yaml.safe_load(f)
logging.info("Loaded config.") logging.info("Loaded config.")
# TODO load other keys with config.get(key, default) instead of config[key] BASE_URL = config.get("base-url", "http://localhost:8080")
BASE_URL = config["base-url"] MAX_SPOT_AGE = config.get("max-spot-age-sec", 3600)
MAX_SPOT_AGE = config["max-spot-age-sec"] MAX_ALERT_AGE = config.get("max-alert-age-sec", 604800)
MAX_ALERT_AGE = config["max-alert-age-sec"] SERVER_OWNER_CALLSIGN = config.get("server-owner-callsign", "N0CALL")
SERVER_OWNER_CALLSIGN = config["server-owner-callsign"] WEB_SERVER_PORT = config.get("web-server-port", 8080)
WEB_SERVER_PORT = config["web-server-port"] ALLOW_SPOTTING = config.get("allow-spotting", True)
ALLOW_SPOTTING = config["allow-spotting"]
ALLOW_UPSTREAM_SPOTTING = config.get("allow-upstream-spotting", True) ALLOW_UPSTREAM_SPOTTING = config.get("allow-upstream-spotting", True)
WEB_UI_OPTIONS = config["web-ui-options"] WEB_UI_OPTIONS = config.get("web-ui-options", {})
API_ONLY_MODE = config.get("api-only-mode", False) API_ONLY_MODE = config.get("api-only-mode", False)
RECAPTCHA_SECRET_KEY = config.get("recaptcha-secret-key", "") RECAPTCHA_SECRET_KEY = config.get("recaptcha-secret-key", "")
RECAPTCHA_SITE_KEY = config.get("recaptcha-site-key", "") RECAPTCHA_SITE_KEY = config.get("recaptcha-site-key", "")

View File

@@ -71,5 +71,6 @@ class HEMA(HTTPSpotProvider):
return sig == "HEMA" return sig == "HEMA"
def submit_spot(self, spot, credentials): def submit_spot(self, spot, credentials):
# TODO: Implement. Spotting to HEMA is covered in the original email from the team. # TODO: Implement. Currently blocked awaiting their API team to make a change to allow us to spot with a
# reference and not a reference *number*.
raise NotImplementedError("HEMA upstream spot submission is not yet implemented") raise NotImplementedError("HEMA upstream spot submission is not yet implemented")

View File

@@ -43,5 +43,6 @@ class WWFF(HTTPSpotProvider):
return sig == "WWFF" return sig == "WWFF"
def submit_spot(self, spot, credentials): def submit_spot(self, spot, credentials):
# TODO: Implement. Spotting to WWFF should be possible, need to look up the Spotline docs or copy approach from PoLo. Either way I think we need an API key for the app (but maybe not for the user?) # TODO: Implement. Spotting to WWFF should be possible, need to look up the Spotline docs or copy approach from
# PoLo. Either way I think we need an API key for the app (but maybe not for the user?)
raise NotImplementedError("WWFF upstream spot submission is not yet implemented") raise NotImplementedError("WWFF upstream spot submission is not yet implemented")