Refactor looking up SIG reference details into a common location, taking it out of the individual spot providers. This means we can now look up references properly from Cluster spot comments, etc. Closes #74 as there is no longer any duplication of these lookups. Works towards #54 as sig_refs now specify their sig internally.

spotproviders/wota.py

@@ -3,8 +3,6 @@ from datetime import datetime
 import pytz
 from rss_parser import RSSParser
 
-from core.cache_utils import SEMI_STATIC_URL_DATA_CACHE
-from core.constants import HTTP_HEADERS
 from core.sig_utils import get_icon_for_sig
 from data.sig_ref import SIGRef
 from data.spot import Spot
@@ -66,21 +64,8 @@ class WOTA(HTTPSpotProvider):
                         freq=freq_hz,
                         mode=mode,
                         comment=comment,
-                        sig="WOTA",
-                        sig_refs=[SIGRef(id=ref, name=ref_name, url="https://www.wota.org.uk/MM_" + ref)] if ref else [],
-                        icon=get_icon_for_sig("WOTA"),
+                        sig_refs=[SIGRef(id=ref, sig="WOTA", name=ref_name)] if ref else [],
                         time=time.timestamp())
 
-            # WOTA name/grid/lat/lon lookup
-            if ref:
-                wota_data = SEMI_STATIC_URL_DATA_CACHE.get(self.LIST_URL, headers=HTTP_HEADERS).json()
-                for feature in wota_data["features"]:
-                    if feature["properties"]["wotaId"] == ref:
-                        spot.sig_refs[0].name = feature["properties"]["title"]
-                        spot.dx_latitude = feature["geometry"]["coordinates"][1]
-                        spot.dx_longitude = feature["geometry"]["coordinates"][0]
-                        spot.dx_grid = feature["properties"]["qthLocator"]
-                        break
-
             new_spots.append(spot)
         return new_spots