Fix static analysis issues

core/config.py

@@ -10,7 +10,8 @@ if not os.path.isfile("config.yml"):
     exit()
 
 # Load config
-config = yaml.safe_load(open("config.yml"))
+with open("config.yml") as f:
+    config = yaml.safe_load(f)
 logging.info("Loaded config.")
 
 MAX_SPOT_AGE = config["max-spot-age-sec"]
@@ -23,7 +24,7 @@ WEB_UI_OPTIONS = config["web-ui-options"]
 # For ease of config, each spot provider owns its own config about whether it should be enabled by default in the web UI
 # but for consistency we provide this to the front-end in web-ui-options because it has no impact outside of the web UI.
 WEB_UI_OPTIONS["spot-providers-enabled-by-default"] = [p["name"] for p in config["spot-providers"] if p["enabled"] and (
-        "enabled-by-default-in-web-ui" not in p or p["enabled-by-default-in-web-ui"] == True)]
+        "enabled-by-default-in-web-ui" not in p or p["enabled-by-default-in-web-ui"])]
 # If spotting to this server is enabled, "API" is another valid spot source even though it does not come from
 # one of our proviers. We set that to also be enabled by default.
 if ALLOW_SPOTTING:

core/constants.py

@@ -19,7 +19,7 @@ SIGS = [
     SIG(name="WWBOTA", description="Worldwide Bunkers on the Air", ref_regex=r"B\/[A-Z0-9]{1,3}\-\d{3,4}"),
     SIG(name="HEMA", description="HuMPs Excluding Marilyns Award", ref_regex=r"[A-Z0-9]{1,3}\/[A-Z]{3}\-\d{3}"),
     SIG(name="IOTA", description="Islands on the Air", ref_regex=r"[A-Z]{2}\-\d{3}"),
-    SIG(name="MOTA", description="Mills on the Air", ref_regex=r"X\d{4-6}"),
+    SIG(name="MOTA", description="Mills on the Air", ref_regex=r"X\d{4,6}"),
     SIG(name="ARLHS", description="Amateur Radio Lighthouse Society", ref_regex=r"[A-Z]{3}\-\d{3,4}"),
     SIG(name="ILLW", description="International Lighthouse & Lightship Weekend", ref_regex=r"[A-Z]{2}\d{4}"),
     SIG(name="SIOTA", description="Silos on the Air", ref_regex=r"[A-Z]{2}\-[A-Z]{3}\d"),

core/lookup_helper.py

@@ -103,7 +103,7 @@ class LookupHelper:
             logging.error("Could not download DXCC data, flags and similar data may be missing!")
 
         # Precompile regex matches for DXCCs to improve efficiency when iterating through them
-        for dxcc in self._dxcc_data.values():
+        for dxcc in (self._dxcc_data.values() if self._dxcc_data else []):
             dxcc["_prefixRegexCompiled"] = re.compile(dxcc["prefixRegex"])
 
     def _download_country_files_cty_plist(self):

core/status_reporter.py

@@ -86,6 +86,6 @@ class StatusReporter:
                                           "page_access_count": self._web_server.web_server_metrics["page_access_counter"]}
 
         # Update Prometheus metrics
-        memory_use_gauge.set(psutil.Process(os.getpid()).memory_info().rss * 1024)
+        memory_use_gauge.set(psutil.Process(os.getpid()).memory_info().rss)
         spots_gauge.set(len(self._spots))
         alerts_gauge.set(len(self._alerts))