From 7ee08e2fcdd1afad23f2223ef4f3bf86d49eea15 Mon Sep 17 00:00:00 2001 From: Ian Renton Date: Sat, 25 Jul 2026 15:06:19 +0100 Subject: [PATCH] Bug fixes and map page banner --- core/lookup_helper.py | 18 ++++++++++++------ templates/about.html | 11 ++++++++++- templates/add_spot.html | 2 +- templates/alerts.html | 2 +- templates/bands.html | 4 ++-- templates/base.html | 10 +++++----- templates/conditions.html | 2 +- templates/map.html | 17 +++++++++++++++-- templates/spots.html | 4 ++-- templates/status.html | 2 +- webassets/js/map.js | 14 ++++++++++++-- 11 files changed, 62 insertions(+), 24 deletions(-) diff --git a/core/lookup_helper.py b/core/lookup_helper.py index 598972e..a2a4fd8 100644 --- a/core/lookup_helper.py +++ b/core/lookup_helper.py @@ -502,9 +502,12 @@ class LookupHelper: # Try the call as given, then fall back to the base call (strips /P, /M etc.) calls_to_try = [call] - home_call = callinfo.Callinfo.get_homecall(call) - if home_call != call: - calls_to_try.append(home_call) + try: + home_call = callinfo.Callinfo.get_homecall(call) + if home_call != call: + calls_to_try.append(home_call) + except ValueError: + logging.debug("Could not look up home call for callsign %s", call) for lookup_call in calls_to_try: try: @@ -574,9 +577,12 @@ class LookupHelper: # Try the call as given, then fall back to the base call (strips /P, /M etc.) calls_to_try = [call] - home_call = callinfo.Callinfo.get_homecall(call) - if home_call != call: - calls_to_try.append(home_call) + try: + home_call = callinfo.Callinfo.get_homecall(call) + if home_call != call: + calls_to_try.append(home_call) + except ValueError: + logging.debug("Could not look up home call for callsign %s", call) for lookup_call in calls_to_try: try: diff --git a/templates/about.html b/templates/about.html index 5982461..bbeda55 100644 --- a/templates/about.html +++ b/templates/about.html @@ -159,13 +159,22 @@ modify it however you like, you can claim you wrote it and charge people £1000 for a copy, I don't really mind. (Please don't do the last one. But if you're using my code for something cool, it would be nice to hear from you!)

-

Data Accuracy

+

Data Accuracy

Please note that the data coming out of Spothole is only as good as the data going in. People mis-hear and make typos when spotting callsigns all the time. There are also plenty of cases where Spothole's data, particularly location data, may be inaccurate. For example, there are POTA parks that span multiple US states, countries that span multiple CQ zones, portable operators with no requirement to sign /P, etc. If you are doing something where accuracy is important, such as contesting, you should not rely on Spothole's data to fill in any gaps in your log.

+

In the Spothole user interface, under "Your Data", you can enter your credentials for QRZ.com and/or HamQTH if + you have them. This allows Spothole to augment its data with lookups from these services. See the following + section, Privacy, for details of how these are handled. If you are looking at the map and see lots of spots in + the geographic centre of countries, allowing these lookups will help. For QRZ.com a paid account is required to + look up operator locations.

+

IOTA in particular causes a mapping problem, firstly that there is no official set of geodata beyond the names of + islands. We also have no way of telling whether priority should be given to IOTA reference or e.g. QRZ lookup, + for example for a G callsign in EU-005 Great Britain the QRZ home address is probably more accurate, but in + EU-002 Aaland islands, it's more likely a DXpedition and the IOTA would be more accurate.

Privacy

Spothole collects no data about you on a permanent basis. All spots and alerts are "timed out" and deleted from the system after a set interval, which by default is one hour for spots and one week for alerts.

diff --git a/templates/add_spot.html b/templates/add_spot.html index 863335b..c647075 100644 --- a/templates/add_spot.html +++ b/templates/add_spot.html @@ -76,7 +76,7 @@ - + diff --git a/templates/alerts.html b/templates/alerts.html index 9d20346..f481f14 100644 --- a/templates/alerts.html +++ b/templates/alerts.html @@ -75,7 +75,7 @@ - + diff --git a/templates/bands.html b/templates/bands.html index f2a2083..56e3e49 100644 --- a/templates/bands.html +++ b/templates/bands.html @@ -75,8 +75,8 @@ - - + + diff --git a/templates/base.html b/templates/base.html index 0294bcc..af05a27 100644 --- a/templates/base.html +++ b/templates/base.html @@ -1,6 +1,6 @@ {% extends "skeleton.html" %} {% block head_extra %} - + @@ -10,10 +10,10 @@ - - - - + + + + {% end %} {% block body %}
diff --git a/templates/conditions.html b/templates/conditions.html index a52a48a..92805ca 100644 --- a/templates/conditions.html +++ b/templates/conditions.html @@ -284,7 +284,7 @@
- + diff --git a/templates/map.html b/templates/map.html index 0d4e6ee..d11f6eb 100644 --- a/templates/map.html +++ b/templates/map.html @@ -1,6 +1,19 @@ {% extends "base.html" %} {% block content %} +
+ +
+
@@ -95,8 +108,8 @@ - - + + diff --git a/templates/spots.html b/templates/spots.html index 9ccdf8a..a77bf94 100644 --- a/templates/spots.html +++ b/templates/spots.html @@ -116,8 +116,8 @@ - - + + diff --git a/templates/status.html b/templates/status.html index 7c1dfe4..4f55f4d 100644 --- a/templates/status.html +++ b/templates/status.html @@ -59,7 +59,7 @@
- +