Code review fixes

2026-09-20 22:37:44 +00:00 · 2026-09-18 07:56:08 +01:00
parent 0fa8cd763d
commit a03e1336c8
18 changed files with 113 additions and 66 deletions
@@ -163,9 +163,10 @@ class TelnetServer:
        # Ensure ASCII formatting for telnet clients
        encoded_line = self._format_dxspider_spot(spot).encode("ascii", errors="ignore")

-        # Try to write to all clients, and in the process find the ones that are disconnected
+        # Try to write to all clients, and in the process find the ones that are disconnected. Iterate over a copy
+        # since a new client can connect (mutating self._clients) while we're awaiting a write below.
        disconnected_clients = set()
-        for writer in self._clients:
+        for writer in list(self._clients):
            try:
                writer.write(encoded_line)
                await writer.drain()