Refactor activity names to use an enum instead of a string to avoid typos #147

providers/spot/sota.py

@@ -5,7 +5,8 @@ import requests
 from requests.exceptions import ConnectionError, ConnectTimeout, ReadTimeout
 
 from core.constants import HTTP_HEADERS
-from core.enums import ActivityRefType, Mode
+from core.enums import Mode
+from core.enums import ActivityName, ActivityRefType
 from data.activity_ref import ActivityRef
 from data.spot import Spot
 from providers.spot.http_spot_provider import HTTPSpotProvider
@@ -56,11 +57,11 @@ class SOTA(HTTPSpotProvider):
                         # Seen SOTA spots with no frequency!
                         mode=Mode.from_name(source_spot["mode"].upper()),
                         comment=source_spot["comments"],
-                        sig="SOTA",
+                        sig=ActivityName.SOTA,
                         sig_refs=[
                             ActivityRef(
                                 id=source_spot["summitCode"],
-                                sig="SOTA",
+                                sig=ActivityName.SOTA,
                                 name=source_spot["summitName"],
                                 latitude=source_spot["latitude"],
                                 longitude=source_spot["longitude"],
@@ -83,7 +84,7 @@ class SOTA(HTTPSpotProvider):
         return new_spots
 
     def can_submit_spot(self, activity):
-        return activity == "SOTA"
+        return activity == ActivityName.SOTA
 
     def submit_spot(self, spot, credentials):
         # TODO test this method works