Refactor activity names to use an enum instead of a string to avoid typos #147

webserver/handlers/api/alerts.py

@@ -9,6 +9,7 @@ import tornado_eventsource.handler
 from tornado import httputil
 from tornado.web import Application
 
+from core.enums import ActivityName
 from core.utils import safe_json_dumps
 from data.lookup_credentials import extract_credentials
 
@@ -168,13 +169,13 @@ def alert_allowed_by_query(alert, query):
                 # the alert is a dxpedition, or contests_skip_max_duration_check and the alert is a contest, it also
                 # always passes the check.
                 if (
-                    alert.sig == "DXpedition"
+                    alert.sig == ActivityName.DXPEDITION
                     and "dxpeditions_skip_max_duration_check" in query
                     and query.get("dxpeditions_skip_max_duration_check").upper() == "TRUE"
                 ):
                     continue
                 if (
-                    alert.sig == "Contest"
+                    alert.sig == ActivityName.CONTEST
                     and "contests_skip_max_duration_check" in query
                     and query.get("contests_skip_max_duration_check").upper() == "TRUE"
                 ):