Refactor activity names to use an enum instead of a string to avoid typos #147

webserver/handlers/api/options.py

@@ -6,9 +6,10 @@ from tornado import httputil
 from tornado.web import Application
 
 from core.config import ALLOW_SPOTTING, MAX_SPOT_AGE
-from core.constants import ACTIVITIES, BANDS, PROPAGATION_MODES
+from core.constants import BANDS, PROPAGATION_MODES
 from core.enums import Continent, Mode, ModeType
 from core.utils import safe_json_dumps
+from data.activities import ACTIVITIES
 
 logger = logging.getLogger(__name__)
 
@@ -39,7 +40,7 @@ class APIOptionsHandler(tornado.web.RequestHandler):
             # for provider in self._spot_providers:
             #     if not provider.enabled:
             #         continue
-            #     for activity in ACTIVITIES:
+            #     for activity in ACTIVITIES.values():
             #         if provider.can_submit_spot(activity.name):
             #             spot_submit_providers.setdefault(activity.name, []).append(provider.name)
 
@@ -74,7 +75,7 @@ class APIOptionsHandler(tornado.web.RequestHandler):
                 "bands": BANDS,
                 "modes": [m.value for m in Mode],
                 "mode_types": [t.value for t in ModeType],
-                "sigs": ACTIVITIES,
+                "sigs": list(ACTIVITIES.values()),
                 "spot_providers": spot_providers,
                 "spot_providers_enabled_by_default": spot_providers_enabled_by_default,
                 "alert_providers": alert_providers,