Improve error reporting

alertproviders/http_alert_provider.py

@@ -4,6 +4,7 @@ from threading import Thread, Event
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from alertproviders.alert_provider import AlertProvider
 from core.constants import HTTP_HEADERS

core/lookup_helper.py

@@ -11,6 +11,7 @@ from pyhamtools import LookupLib, Callinfo, callinfo
 from pyhamtools.exceptions import APIKeyMissingError
 from pyhamtools.frequency import freq_to_band
 from pyhamtools.locator import latlong_to_locator
+from requests.exceptions import ConnectionError
 from requests_cache import CachedSession
 
 from core.cache_utils import SEMI_STATIC_URL_DATA_CACHE

core/sig_utils.py

@@ -2,6 +2,7 @@ import csv
 import logging
 
 from pyhamtools.locator import latlong_to_locator, locator_to_latlong
+from requests.exceptions import ConnectionError
 
 from core.cache_utils import SEMI_STATIC_URL_DATA_CACHE
 from core.constants import SIGS, HTTP_HEADERS

server/handlers/quietstaticfilehandler.py

@@ -0,0 +1,16 @@
+import logging
+
+from tornado.web import StaticFileHandler, HTTPError
+
+
+class QuietStaticFileHandler(StaticFileHandler):
+    """Minor override of logging in StaticFileHandler to log HTTP errors at debug level instead of their usual
+    warning level. Without this, attacks on Spothole which try to do path traversal attacks would log exceptions
+    from inside Tornado, and the server logs would contain a lot of this type of content. This effectively changes
+    the log level of these exceptions to DEBUG so they are only logged if DEBUG level logging is enabled."""
+
+    def log_exception(self, typ, value, tb):
+        if isinstance(value, HTTPError):
+            logging.debug(value)
+            return
+        super().log_exception(typ, value, tb)

server/webserver.py

@@ -103,7 +103,7 @@ class WebServer:
         misc_routes = [
             (r"/apidocs", PageTemplateHandler, {"template_name": "apidocs", **handler_opts}),
             (r"/metrics", PrometheusMetricsHandler),
-            (r"/(.*)", StaticFileHandler, {"path": os.path.join(_HERE, "../webassets")})
+            (r"/(.*)", QuietStaticFileHandler, {"path": os.path.join(_HERE, "../webassets")})
         ]
 
         app = tornado.web.Application(api_routes + ui_routes + misc_routes,

solarconditionsproviders/giroionosonde.py

@@ -5,6 +5,7 @@ from threading import Thread, Event
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from solarconditionsproviders.ionosonde_utils import compute_band_states

solarconditionsproviders/http_solar_conditions_provider.py

@@ -4,6 +4,7 @@ from threading import Thread, Event
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from solarconditionsproviders.solar_conditions_provider import SolarConditionsProvider

solarconditionsproviders/kc2gprop.py

@@ -4,6 +4,7 @@ from threading import Thread, Event
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from solarconditionsproviders.ionosonde_utils import compute_band_states

spotproviders/hema.py

@@ -4,6 +4,7 @@ from datetime import datetime
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from data.sig_ref import SIGRef

spotproviders/http_spot_provider.py

@@ -4,6 +4,7 @@ from threading import Thread, Event
 
 import pytz
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from spotproviders.spot_provider import SpotProvider

spotproviders/sota.py

@@ -2,6 +2,7 @@ import logging
 from datetime import datetime
 
 import requests
+from requests.exceptions import ConnectionError
 
 from core.constants import HTTP_HEADERS
 from data.sig_ref import SIGRef

templates/add_spot.html

@@ -76,7 +76,7 @@
 
 </div>
 
-<script src="/js/add-spot.js?v=1784968398"></script>
+<script src="/js/add-spot.js?v=1784983342"></script>
 <script>$(document).ready(function () {
     $("#nav-link-add-spot").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/alerts.html

@@ -75,7 +75,7 @@
 
 </div>
 
-<script src="/js/alerts.js?v=1784968398"></script>
+<script src="/js/alerts.js?v=1784983342"></script>
 <script>$(document).ready(function () {
     $("#nav-link-alerts").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/bands.html

@@ -75,8 +75,8 @@
 <script>
     let spotProvidersEnabledByDefault = {% raw json_encode(web_ui_options["spot-providers-enabled-by-default"]) %};
 </script>
-<script src="/js/spotsbandsandmap.js?v=1784968398"></script>
+<script src="/js/spotsbandsandmap.js?v=1784983342"></script>
-<script src="/js/bands.js?v=1784968398"></script>
+<script src="/js/bands.js?v=1784983342"></script>
 <script>$(document).ready(function () {
     $("#nav-link-bands").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/base.html

@@ -1,6 +1,6 @@
 {% extends "skeleton.html" %}
 {% block head_extra %}
-<link rel="stylesheet" href="/css/style.css?v=1784968398" type="text/css">
+<link rel="stylesheet" href="/css/style.css?v=1784983342" type="text/css">
 <link href="/vendor/css/bootstrap-5.3.8.min.css" rel="stylesheet">
 <link href="/vendor/css/fontawesome-6.7.2.min.css" rel="stylesheet">
 <link href="/vendor/css/solid-6.7.2.min.css" rel="stylesheet">
@@ -10,10 +10,10 @@
 <script src="/vendor/js/bootstrap-5.3.8.bundle.min.js"></script>
 <script src="/vendor/js/tinycolor2-1.6.0.min.js"></script>
 
-<script src="/js/utils.js?v=1784968398"></script>
+<script src="/js/utils.js?v=1784983342"></script>
-<script src="/js/ui-ham.js?v=1784968398"></script>
+<script src="/js/ui-ham.js?v=1784983342"></script>
-<script src="/js/geo.js?v=1784968398"></script>
+<script src="/js/geo.js?v=1784983342"></script>
-<script src="/js/common.js?v=1784968398"></script>
+<script src="/js/common.js?v=1784983342"></script>
 {% end %}
 {% block body %}
 <div class="container">

templates/conditions.html

@@ -284,7 +284,7 @@
 </div>
 
 <script src="/vendor/js/chart-4.4.9.umd.min.js"></script>
-<script src="/js/conditions.js?v=1784968398"></script>
+<script src="/js/conditions.js?v=1784983342"></script>
 <script>$(document).ready(function () {
     $("#nav-link-conditions").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/map.html

@@ -95,8 +95,8 @@
 <script>
     let spotProvidersEnabledByDefault = {% raw json_encode(web_ui_options["spot-providers-enabled-by-default"]) %};
 </script>
-<script src="/js/spotsbandsandmap.js?v=1784968398"></script>
+<script src="/js/spotsbandsandmap.js?v=1784983341"></script>
-<script src="/js/map.js?v=1784968398"></script>
+<script src="/js/map.js?v=1784983341"></script>
 <script>$(document).ready(function () {
     $("#nav-link-map").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/spots.html

@@ -116,8 +116,8 @@
 <script>
     let spotProvidersEnabledByDefault = {% raw json_encode(web_ui_options["spot-providers-enabled-by-default"]) %};
 </script>
-<script src="/js/spotsbandsandmap.js?v=1784968398"></script>
+<script src="/js/spotsbandsandmap.js?v=1784983341"></script>
-<script src="/js/spots.js?v=1784968398"></script>
+<script src="/js/spots.js?v=1784983341"></script>
 <script>$(document).ready(function () {
     $("#nav-link-spots").addClass("active");
 }); <!-- highlight active page in nav --></script>

templates/status.html

@@ -59,7 +59,7 @@
     </div>
 </div>
 
-<script src="/js/status.js?v=1784968398"></script>
+<script src="/js/status.js?v=1784983342"></script>
 <script>
     $(document).ready(function () {
         $("#nav-link-status").addClass("active");